Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php cs & stylelint #1690

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Add php cs & stylelint #1690

merged 2 commits into from
Jul 9, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 9, 2020

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement New feature or request labels Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1690 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1690   +/-   ##
=========================================
  Coverage     67.16%   67.16%           
  Complexity       15       15           
=========================================
  Files             5        5           
  Lines            67       67           
=========================================
  Hits             45       45           
  Misses           22       22           
Impacted Files Coverage Δ Complexity Δ
lib/AppInfo/Application.php 0.00% <ø> (ø) 2.00 <0.00> (ø)
lib/Controller/PageController.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
lib/ContactsMenu/Providers/DetailsProvider.php 96.87% <100.00%> (ø) 11.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0141884...8cd975f. Read the comment docs.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enh/php-cs branch 2 times, most recently from 46927f3 to cd68dca Compare July 9, 2020 15:27
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv changed the title Add php cs Add php cs & stylelint Jul 9, 2020
@skjnldsv skjnldsv merged commit 093878a into master Jul 9, 2020
@skjnldsv skjnldsv deleted the enh/php-cs branch July 9, 2020 15:34
@skjnldsv skjnldsv added this to the 3.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants